<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124739/">https://git.reviewboard.kde.org/r/124739/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Whoa nice job! This fixes moving of tabs and also dragging a tab outside its window to create another window. Thanks a lot.</p></pre>
<br />
<p>- Kurt Hindenburg</p>
<br />
<p>On August 16th, 2015, 9:43 p.m. UTC, David Edmundson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By David Edmundson.</div>
<p style="color: grey;"><i>Updated Aug. 16, 2015, 9:43 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KTabBar used to do internal drag & drop re-ordering
Konsole massively expanded on this to do cross window drag & drop.
Now Qt does tabbar reordering, but Konsole relied on KTabBar's signals
to say when a drag start before overriding the rest.
To solve this I've added the same drag start signal manually into
Konsole's tab bar.
BUG: 348057</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ViewContainer.cpp <span style="color: grey">(02be309fbd22cf52ea963bbd11c0e589b1e5004a)</span></li>
<li>src/ViewContainerTabBar.h <span style="color: grey">(0e2985fd53021edbc9f5fb58aeadd40c564728bf)</span></li>
<li>src/ViewContainerTabBar.cpp <span style="color: grey">(399c391d619d23b34bb03be9f61417931f80ee51)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124739/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>