[Konsole-devel] Review Request 120763: Add new signal : backgroundProcessPwdChanged

Arjun AK arjunak234 at gmail.com
Thu Oct 23 20:58:10 UTC 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120763/
-----------------------------------------------------------

Review request for Konsole, Emmanuel Pescosta and Frank Reininghaus.


Bugs: 305085
    http://bugs.kde.org/show_bug.cgi?id=305085


Repository: konsole


Description
-------

Listening to the currentDirectoryChanged() can cause dolphin to act weird when you have programs running on the konsole part. for instance:

1) `$ man ls` -> Dolphin temporarily switches to the manpages directory
2) `$ man ls`. Now quickly press q and CTRL D, you get stuck in the manpages directory.
3) `(cd /;sleep .5; cd /tmp; sleep .5)`
4) When you have scripts running(like kdesrc-build), dolphin keeps on changing the directories

By adding a new signal, which is only emitted when the PWD of the shell is changed, these [bugs](https://bugs.kde.org/show_bug.cgi?id=305085) can be fixed.


Diffs
-----

  src/Part.h 646e3aa 
  src/Part.cpp cb556cc 
  src/Session.h 6cd283a 
  src/Session.cpp cf70c09 
  src/SessionController.h 4a7d094 
  src/SessionController.cpp cc9db5f 

Diff: https://git.reviewboard.kde.org/r/120763/diff/


Testing
-------


Thanks,

Arjun AK

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20141023/ca9afea2/attachment.html>


More information about the konsole-devel mailing list