<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120763/">https://git.reviewboard.kde.org/r/120763/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konsole, Emmanuel Pescosta and Frank Reininghaus.</div>
<div>By Arjun AK.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=305085">305085</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Listening to the currentDirectoryChanged() can cause dolphin to act weird when you have programs running on the konsole part. for instance:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$ man ls</code> -> Dolphin temporarily switches to the manpages directory
2) <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">$ man ls</code>. Now quickly press q and CTRL D, you get stuck in the manpages directory.
3) <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">(cd /;sleep .5; cd /tmp; sleep .5)</code>
4) When you have scripts running(like kdesrc-build), dolphin keeps on changing the directories</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">By adding a new signal, which is only emitted when the PWD of the shell is changed, these <a href="https://bugs.kde.org/show_bug.cgi?id=305085" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">bugs</a> can be fixed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Part.h <span style="color: grey">(646e3aa)</span></li>
<li>src/Part.cpp <span style="color: grey">(cb556cc)</span></li>
<li>src/Session.h <span style="color: grey">(6cd283a)</span></li>
<li>src/Session.cpp <span style="color: grey">(cf70c09)</span></li>
<li>src/SessionController.h <span style="color: grey">(4a7d094)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(cc9db5f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120763/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>