[Konsole-devel] Review Request 104038: A experimental hack to support escape sequence for resizing

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/104038/
-----------------------------------------------------------

(Updated Feb. 12, 2014, 2:57 p.m.)


Status
------

This change has been discarded.


Review request for Konsole.


Bugs: 238073
    http://bugs.kde.org/show_bug.cgi?id=238073


Repository: konsole


Description
-------

The first existing problem is when such escape sequence is received, Vt102Emulation does not emit related signal, and SessionController::sessionResizeRequest() is not triggered. That is not hard to fix.

However, the harder problem is when TerminalDisplay::setSize() is called, it only change the sizeHint of the terminal area. So nothing changes unless we tell the mainwindow to resize itself manually. This is the another thing this experimental patch does.

Well, this patch does not work correctly. The left problem is I have to send the same escape sequence twice to make the mainwindow actually resize. For example, echo -ne "\033[8;25;80t" does not cause any effect; I have to repeat that again to make the mainwindow really resize to the specifed size.

As you can see from the patch, I'm really a bit lost on how to really fix it correctly and elegantly. Hope the patch can give others some hint, especially the left problem mentioned in last paragraph.


Diffs
-----

  src/Emulation.h 8390a25 
  src/MainWindow.h 23ae033 
  src/MainWindow.cpp 1e30232 
  src/Session.cpp 0912596 
  src/SessionController.h 7de6b20 
  src/SessionController.cpp 5284179 
  src/TerminalDisplay.h 7354991 
  src/Vt102Emulation.cpp 8251d1a 

Diff: https://git.reviewboard.kde.org/r/104038/diff/


Testing
-------


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140212/ef247613/attachment-0001.html>