<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/104038/">https://git.reviewboard.kde.org/r/104038/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2014, 2:57 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=238073">238073</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The first existing problem is when such escape sequence is received, Vt102Emulation does not emit related signal, and SessionController::sessionResizeRequest() is not triggered. That is not hard to fix.
However, the harder problem is when TerminalDisplay::setSize() is called, it only change the sizeHint of the terminal area. So nothing changes unless we tell the mainwindow to resize itself manually. This is the another thing this experimental patch does.
Well, this patch does not work correctly. The left problem is I have to send the same escape sequence twice to make the mainwindow actually resize. For example, echo -ne "\033[8;25;80t" does not cause any effect; I have to repeat that again to make the mainwindow really resize to the specifed size.
As you can see from the patch, I'm really a bit lost on how to really fix it correctly and elegantly. Hope the patch can give others some hint, especially the left problem mentioned in last paragraph.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/Emulation.h <span style="color: grey">(8390a25)</span></li>
<li>src/MainWindow.h <span style="color: grey">(23ae033)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(1e30232)</span></li>
<li>src/Session.cpp <span style="color: grey">(0912596)</span></li>
<li>src/SessionController.h <span style="color: grey">(7de6b20)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(5284179)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(7354991)</span></li>
<li>src/Vt102Emulation.cpp <span style="color: grey">(8251d1a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/104038/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>