[Konsole-devel] Review Request 103952: allow specifying perferred terminal size per profile

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/103952/#review49657
-----------------------------------------------------------


I'll discard this review - look at https://git.reviewboard.kde.org/r/115628/ for my new attempt

- Kurt Hindenburg


On Feb. 12, 2012, 6:06 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/103952/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2012, 6:06 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Bugs: 152385
>     http://bugs.kde.org/show_bug.cgi?id=152385
> 
> 
> Repository: konsole
> 
> 
> Description
> -------
> 
> To start with, this is not a fully-working patch. Its main purpose is for demonstrating the idea and implementation. It seems I abuse reviewboard for unmature patch quite often recently :)
> 
> 
> What this patch does: 
> 
>   * Add two properties into profile: "TerminalSizeInColumns" and "TerminalSizeInRows" under the [General] group; Default size is 80x40. No related GUI yet.
>   * When creating view for session, use the preferred size in the associated profile instead of the hardcoded 80x40.
>   * Move the "Save window size and position on exit" from profiles into global settings.
> 
> 
> What works:
> 
>   * When konsolerc does not contain height and width information under the [MainWindow] group and the "Save window size..." global option is disabled, konsole --profile "xxxx" creates a terminal window according to the preferred 
> terminal size in the speficied profile.
> 
> 
> What does not works:
> 
>   * when konsolerc contains height and width information under the [MainWindow] group, this patch just does not work. The created window always uses previously saved size.
> 
> 
> What is the lefted problem to *solve* ?
> 
>   * only not saving geometry information on exit is not enough. We need to find some way to prevent KMainWindow from restoring window size when konsolerc contains width and height under the [MainWindow] group. I just failed to find how to.
> 
> 
> What needs to be done to improve the patch:
> 
>   * Sovle the probem mentioned above, of course
>   * Rename "Save window size ...." option into "Use previous window size", which is more straight forward.
>   * Add GUI for configuring that two new profile properties.
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.h 4d0d3cb 
>   src/MainWindow.cpp 2881d2a 
>   src/Profile.h d78e723 
>   src/Profile.cpp d617e9e 
>   src/Session.h b03b830 
>   src/Session.cpp 5bb0463 
>   src/SessionManager.cpp 0c0bae3 
>   src/ViewManager.cpp f39cda4 
>   src/settings/GeneralSettings.cpp 7fc8467 
> 
> Diff: https://git.reviewboard.kde.org/r/103952/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20140212/9aa2c0b9/attachment.html>