<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/103952/">https://git.reviewboard.kde.org/r/103952/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'll discard this review - look at https://git.reviewboard.kde.org/r/115628/ for my new attempt</pre>
<br />
<p>- Kurt Hindenburg</p>
<br />
<p>On February 12th, 2012, 6:06 p.m. UTC, Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2012, 6:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=152385">152385</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konsole
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">To start with, this is not a fully-working patch. Its main purpose is for demonstrating the idea and implementation. It seems I abuse reviewboard for unmature patch quite often recently :)
What this patch does:
* Add two properties into profile: "TerminalSizeInColumns" and "TerminalSizeInRows" under the [General] group; Default size is 80x40. No related GUI yet.
* When creating view for session, use the preferred size in the associated profile instead of the hardcoded 80x40.
* Move the "Save window size and position on exit" from profiles into global settings.
What works:
* When konsolerc does not contain height and width information under the [MainWindow] group and the "Save window size..." global option is disabled, konsole --profile "xxxx" creates a terminal window according to the preferred
terminal size in the speficied profile.
What does not works:
* when konsolerc contains height and width information under the [MainWindow] group, this patch just does not work. The created window always uses previously saved size.
What is the lefted problem to *solve* ?
* only not saving geometry information on exit is not enough. We need to find some way to prevent KMainWindow from restoring window size when konsolerc contains width and height under the [MainWindow] group. I just failed to find how to.
What needs to be done to improve the patch:
* Sovle the probem mentioned above, of course
* Rename "Save window size ...." option into "Use previous window size", which is more straight forward.
* Add GUI for configuring that two new profile properties.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.h <span style="color: grey">(4d0d3cb)</span></li>
<li>src/MainWindow.cpp <span style="color: grey">(2881d2a)</span></li>
<li>src/Profile.h <span style="color: grey">(d78e723)</span></li>
<li>src/Profile.cpp <span style="color: grey">(d617e9e)</span></li>
<li>src/Session.h <span style="color: grey">(b03b830)</span></li>
<li>src/Session.cpp <span style="color: grey">(5bb0463)</span></li>
<li>src/SessionManager.cpp <span style="color: grey">(0c0bae3)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(f39cda4)</span></li>
<li>src/settings/GeneralSettings.cpp <span style="color: grey">(7fc8467)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/103952/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>