[Konsole-devel] [konsole] [Bug 198175] Konsole should set blur region for the new kwin effect

[Martin Sandsmark]

https://bugs.kde.org/show_bug.cgi?id=198175

--- Comment #55 from Martin Sandsmark <martin.sandsmark at kde.org> ---
(In reply to comment #51)
> what is irrelevant for the actual problem.

No, since that is the "official" API for setting a blur region.

> Still insufficient, since it can be crossed by other sources.
> The feature needs to be moved into some central instance, eg.
> QWidget/QApplication, a dedicated platform plugin or the style (which
> effectively is a platform plugin) - otherwise no plain Qt app could make use
> of this if it has to "fear" that eg. the oxygen-transparent style would
> still override it - even by this approach.

Then "too bad", IMHO. We can't have a perfect approach.

> If you want to add this from a third party, you need a manager, tracking
> dynamic QWidget properties (set to the blur region) and move/resize events
> to form a new region and export that at the end of the event cycle.

This would still get fucked by for example oxygen-transparent.

> Since konsole btw. explicitly links X11 libs, you could just  copy over the
> plasma funtion (so konsole won't suddenly drag in webkit and whatnot)

Yes, that's what I originally did, but then didn't find the existing parts
where it looked for X11, and just linking against another part of kdelibs was
easier. :-)

> > I changed it to using rect() locally
> like "0,0,width,height" ::rect() or mapped to the window?
> You also need to monitor any translation of the widgets geometry relative to
> the window, ie. when it moves inside its parent or any of its ancestors
> moves.

Yeah, I just used QWidget::rect(), which obviously doesn't account for window
borders, I see.

I guess the simpler approach would be to let it blur behind the entire window
if blurring is turned on in the profile.

-- 
You are receiving this mail because:
You are the assignee for the bug.