[Konsole-devel] Review Request 110535: [ColorSchemeEditor improvements v2](part5): Transform ColorSchemeEditor class from Qwidget to Kdialog

[renan fargetton]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110535/
-----------------------------------------------------------

(Updated May 20, 2013, 3:33 p.m.)


Status
------

This change has been discarded.


Review request for Konsole.


Description
-------

This one is the main of the serie :
 - Transform ColorSchemeEditor class from Qwidget to Kdialog
 - Move some code from EditProfileDialog::showColorSchemeEditor
    * a part went into the newly created slot EditProfileDialog::saveColorScheme
    * a part becomes obsolete since ColorSchemeEditor is the whole Kdialog
    * a small part went into ColorSchemeEditor constructor
 - Make  ColorSchemeEditor a non-modal dialog : The terminal is not frozen when the dialog is open
 - The Kdialog has an Apply button
 - Some safeguard to check that there is only one ColorSchemeEditor open


Diffs
-----

  src/ColorSchemeEditor.h 9b1e4b2 
  src/ColorSchemeEditor.cpp 421f613 
  src/EditProfileDialog.h 9f45200 
  src/EditProfileDialog.cpp f30856d 

Diff: http://git.reviewboard.kde.org/r/110535/diff/


Testing
-------

Compile / run


Thanks,

renan fargetton

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130520/23505446/attachment.html>