[Konsole-devel] Review Request 110535: [ColorSchemeEditor improvements v2](part5): Transform ColorSchemeEditor class from Qwidget to Kdialog

[renan fargetton]

> On May 20, 2013, 2:42 p.m., renan fargetton wrote:
> > src/ColorSchemeEditor.cpp, line 268
> > <http://git.reviewboard.kde.org/r/110535/diff/1/?file=145228#file145228line268>
> >
> >     I just realized this won't work without part3 patch.
> 
> Kurt Hindenburg wrote:
>     yep was trying to compile it now - we put put part3 in - 
>     
>     A side note - try to watch your spaces around () - there should be none; and add space after ,
>
> 
> renan fargetton wrote:
>     Also I could split further this patch. Should I ?
> 
> Kurt Hindenburg wrote:
>     I'm about to head off to work - if you want to combine the remaining patches into 1, I'll look at later tonight.
>     
>     Thanks

Okay, I'm doing it.

Thanks for your reviews and comments


- renan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110535/#review32825
-----------------------------------------------------------


On May 20, 2013, 4:26 a.m., renan fargetton wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110535/
> -----------------------------------------------------------
> 
> (Updated May 20, 2013, 4:26 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This one is the main of the serie :
>  - Transform ColorSchemeEditor class from Qwidget to Kdialog
>  - Move some code from EditProfileDialog::showColorSchemeEditor
>     * a part went into the newly created slot EditProfileDialog::saveColorScheme
>     * a part becomes obsolete since ColorSchemeEditor is the whole Kdialog
>     * a small part went into ColorSchemeEditor constructor
>  - Make  ColorSchemeEditor a non-modal dialog : The terminal is not frozen when the dialog is open
>  - The Kdialog has an Apply button
>  - Some safeguard to check that there is only one ColorSchemeEditor open
> 
> 
> Diffs
> -----
> 
>   src/ColorSchemeEditor.h 9b1e4b2 
>   src/ColorSchemeEditor.cpp 421f613 
>   src/EditProfileDialog.h 9f45200 
>   src/EditProfileDialog.cpp f30856d 
> 
> Diff: http://git.reviewboard.kde.org/r/110535/diff/
> 
> 
> Testing
> -------
> 
> Compile / run
> 
> 
> Thanks,
> 
> renan fargetton
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130520/c72571e9/attachment-0001.html>