[Konsole-devel] Review Request 111441: Fix many selection related bugs including selecting invisible region on double/triple click

[Kurt Hindenburg]

> On July 14, 2013, 8:28 p.m., Yichao Yu wrote:
> > Ping.
> > Can anyone please have a look at the patch?
> >
> 
> Kurt Hindenburg wrote:
>     Yes I'm still looking at it - thanks for the patch btw
> 
> Yichao Yu wrote:
>     :) Just hope these issues can be fixed in the coming release (whether with this patch or not).
>
> 
> Yichao Yu wrote:
>     Hi, we are only ~1 week from 4.11 tagging. Is it still possible to get this fix into the 4.11 release?
>

I need to look at this more to verify there are no regressions - usually I don't like adding code just before the final tagging.

I will likely have to rewrite the 4 routines - I don't like the loops and in general goto's should be rewritten.


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111441/#review35949
-----------------------------------------------------------


On July 7, 2013, 10:41 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111441/
> -----------------------------------------------------------
> 
> (Updated July 7, 2013, 10:41 p.m.)
> 
> 
> Review request for Konsole and Kurt Hindenburg.
> 
> 
> Description
> -------
> 
> This patch fixes many bugs related to selection in konsole including:
> 1, bug#319260, double/triple click can only select text within visible region.
> 2, triple click in SelectForwardsFromCursor mode will start the selection from the corresponding position in the first visible line (line on the screen) of the current "logical" line.
> 3, excluding "@" in word selection mode is not working if the end of the selection is at the left (after line wrap) of the beginning.
> 4, excluding "@" in word selection mode is not working as soon as there is a mouse moving event, even if only by a tiny amount.
> 
> 
> This addresses bug 319260.
>     http://bugs.kde.org/show_bug.cgi?id=319260
> 
> 
> Diffs
> -----
> 
>   src/TerminalDisplay.h 100ffcc 
>   src/TerminalDisplay.cpp acfddc1 
> 
> Diff: http://git.reviewboard.kde.org/r/111441/diff/
> 
> 
> Testing
> -------
> 
> Compiled and tested for a lot of cases.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130731/3958fc3a/attachment.html>