<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111441/">http://git.reviewboard.kde.org/r/111441/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 14th, 2013, 8:28 p.m. UTC, <b>Yichao Yu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ping.
Can anyone please have a look at the patch?
</pre>
</blockquote>
<p>On July 14th, 2013, 9:01 p.m. UTC, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes I'm still looking at it - thanks for the patch btw</pre>
</blockquote>
<p>On July 17th, 2013, 1:55 p.m. UTC, <b>Yichao Yu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">:) Just hope these issues can be fixed in the coming release (whether with this patch or not).
</pre>
</blockquote>
<p>On July 30th, 2013, 4:38 p.m. UTC, <b>Yichao Yu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi, we are only ~1 week from 4.11 tagging. Is it still possible to get this fix into the 4.11 release?
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I need to look at this more to verify there are no regressions - usually I don't like adding code just before the final tagging.
I will likely have to rewrite the 4 routines - I don't like the loops and in general goto's should be rewritten.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On July 7th, 2013, 10:41 p.m. UTC, Yichao Yu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole and Kurt Hindenburg.</div>
<div>By Yichao Yu.</div>
<p style="color: grey;"><i>Updated July 7, 2013, 10:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch fixes many bugs related to selection in konsole including:
1, bug#319260, double/triple click can only select text within visible region.
2, triple click in SelectForwardsFromCursor mode will start the selection from the corresponding position in the first visible line (line on the screen) of the current "logical" line.
3, excluding "@" in word selection mode is not working if the end of the selection is at the left (after line wrap) of the beginning.
4, excluding "@" in word selection mode is not working as soon as there is a mouse moving event, even if only by a tiny amount.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and tested for a lot of cases.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319260">319260</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/TerminalDisplay.h <span style="color: grey">(100ffcc)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(acfddc1)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111441/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>