[Konsole-devel] Review Request 108461: Make libKonq optional

[Francesco Cecconi]

> On Jan. 20, 2013, 12:51 p.m., Francesco Cecconi wrote:
> > is it not more simple to use a "option" macro ?
> > 
> > option(KONSOLE_BUILD_LIBKONQ "Support for..." ON)
> > 
> > if (KONSOLE_BUILD_LIBKONQ)
> > find_package(LibKonq)
> > macro_log_feature(LIBKONQ_FOUND "LibKonq" "libkonq is a construction kit for a file manager. It comes from kde-baseapps." "http://www.kde.org" TRUE)
> > endif (KONSOLE_BUILD_LIBKONQ)
> 
> Kurt Hindenburg wrote:
>     I'll try that - from what I gather macro_optional_find_package actually uses OPTION - however I didn't see how to set a default

from the macro definition the default value is ON

macro (MACRO_OPTIONAL_FIND_PACKAGE _name )
   option(WITH_${_name} "Search for ${_name} package" ON)
   if (WITH_${_name})
      find_package(${_name} ${ARGN})
   else (WITH_${_name})
      string(TOUPPER ${_name} _nameUpper)
      set(${_name}_FOUND FALSE)
      set(${_nameUpper}_FOUND FALSE)

      _mofp_set_empty_if_defined(${_name} INCLUDE_DIRS)
      _mofp_set_empty_if_defined(${_name} INCLUDE_DIR)
      _mofp_set_empty_if_defined(${_name} INCLUDES)
      _mofp_set_empty_if_defined(${_name} LIBRARY)
      _mofp_set_empty_if_defined(${_name} LIBRARIES)
      _mofp_set_empty_if_defined(${_name} LIBS)
      _mofp_set_empty_if_defined(${_name} FLAGS)
      _mofp_set_empty_if_defined(${_name} DEFINITIONS)
   endif (WITH_${_name})
endmacro (MACRO_OPTIONAL_FIND_PACKAGE)


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108461/#review25838
-----------------------------------------------------------


On Jan. 19, 2013, 5:13 a.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108461/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2013, 5:13 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I meant to do this earlier - this change allows konsole to build w/o libKonq - I've come across system w/o the libKonq installed.  You look the dnd menus w/o  libKonq.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 7829e13 
>   src/TerminalDisplay.cpp a2c5621 
> 
> Diff: http://git.reviewboard.kde.org/r/108461/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130120/6a04f3fd/attachment.html>