[Konsole-devel] Review Request 108461: Make libKonq optional

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108461/#review25765
-----------------------------------------------------------


I think that optional dependency is good. But the way it is done can be improved. 

It is better to introduce one cmake option to allow users/packagers to explicitly controll whether the libkonq feature should be enabled. In order not to introduce dependency change and feature lost by default, the default value of that option should mimic the current state: requiring libkonq .


See http://www.gentoo.org/proj/en/qa/automagic.xml

- Jekyll Wu


On Jan. 18, 2013, 3:34 a.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108461/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2013, 3:34 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I meant to do this earlier - this change allows konsole to build w/o libKonq - I've come across system w/o the libKonq installed.  You look the dnd menus w/o  libKonq.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 7829e13 
>   src/TerminalDisplay.cpp a2c5621 
> 
> Diff: http://git.reviewboard.kde.org/r/108461/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130118/4ddcc350/attachment.html>