<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108461/">http://git.reviewboard.kde.org/r/108461/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think that optional dependency is good. But the way it is done can be improved.
It is better to introduce one cmake option to allow users/packagers to explicitly controll whether the libkonq feature should be enabled. In order not to introduce dependency change and feature lost by default, the default value of that option should mimic the current state: requiring libkonq .
See http://www.gentoo.org/proj/en/qa/automagic.xml</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On January 18th, 2013, 3:34 a.m. UTC, Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated Jan. 18, 2013, 3:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I meant to do this earlier - this change allows konsole to build w/o libKonq - I've come across system w/o the libKonq installed. You look the dnd menus w/o libKonq.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(7829e13)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(a2c5621)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108461/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>