[Konsole-devel] Review Request 104717: split view: automatically close the split area if it becomes empty.

[Kurt Hindenburg]

> On Aug. 13, 2013, 1:10 p.m., Kurt Hindenburg wrote:
> > At this point, let's commit this.  It works fine on Linux - my MacOSX has issues even w/o this patch.
> > 
> > Let me know if you want me to commit it.

Thanks for keeping up w/ this - I notice you can still close the last tab using the Menu->Detach Current Tab.  We might get around to that later.


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104717/#review37689
-----------------------------------------------------------


On Aug. 15, 2013, 9:41 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104717/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2013, 9:41 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> automatically close blank split, after that last tab is moved.
> 
> 
> This addresses bug 275771.
>     http://bugs.kde.org/show_bug.cgi?id=275771
> 
> 
> Diffs
> -----
> 
>   src/ViewContainer.h d5bdf73 
>   src/ViewContainer.cpp 63c187d 
>   src/ViewContainerTabBar.h 5b97abc 
>   src/ViewContainerTabBar.cpp c3a9dd1 
>   src/ViewManager.h f039a27 
>   src/ViewManager.cpp 4b9708e 
> 
> Diff: http://git.reviewboard.kde.org/r/104717/diff/
> 
> 
> Testing
> -------
> 
> - one tab + split + one tab -> move split right/left, no blank area
> - from bug: after step 4 no blank area
> 
> seems to work well but more test are necessary. ;)
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130816/a51c3907/attachment.html>