<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104717/">http://git.reviewboard.kde.org/r/104717/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 13th, 2013, 1:10 p.m. UTC, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">At this point, let's commit this. It works fine on Linux - my MacOSX has issues even w/o this patch.
Let me know if you want me to commit it.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for keeping up w/ this - I notice you can still close the last tab using the Menu->Detach Current Tab. We might get around to that later.</pre>
<br />
<p>- Kurt</p>
<br />
<p>On August 15th, 2013, 9:41 p.m. UTC, Francesco Cecconi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Francesco Cecconi.</div>
<p style="color: grey;"><i>Updated Aug. 15, 2013, 9:41 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">automatically close blank split, after that last tab is moved.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- one tab + split + one tab -> move split right/left, no blank area
- from bug: after step 4 no blank area
seems to work well but more test are necessary. ;)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=275771">275771</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/ViewContainer.h <span style="color: grey">(d5bdf73)</span></li>
<li>src/ViewContainer.cpp <span style="color: grey">(63c187d)</span></li>
<li>src/ViewContainerTabBar.h <span style="color: grey">(5b97abc)</span></li>
<li>src/ViewContainerTabBar.cpp <span style="color: grey">(c3a9dd1)</span></li>
<li>src/ViewManager.h <span style="color: grey">(f039a27)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(4b9708e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104717/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>