[Konsole-devel] Review Request 109891: Add customizable display's contents margins

[Mariusz Glebocki]

> On April 9, 2013, 4:25 p.m., Kurt Hindenburg wrote:
> > Thanks for the code - I'll need to test the margin portion.  I think the leaveEvent should have been a separate review - that looks good.
> > 
> > Is there any reason someone would want a non-uniform margins?  Perhaps just 1 option for all 4 sides?  And is there any reason to not center the terminal?

> Is there any reason someone would want a non-uniform margins?  Perhaps just 1 option for all 4 sides?
I'm going to implement a shadow effect for terminal contents, so the use case was terminal embedded in a desktop, with transparent background and shadow with an offset, where margins are used to prevent shadow clipping. On the other hand, it is possible with uniform margins too.

> is there any reason to not center the terminal?
Only one - during window resizing, when the lines or columns count change, the contents image jumps a bit. Someone may not like it, so I just added option to use the old top-left alignment. Another solution is to center the image after some time (like terminal size information hiding).

Anyway, I'm attaching a patch with one parameter for all margins.


- Mariusz


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109891/#review30789
-----------------------------------------------------------


On April 7, 2013, 7:45 a.m., Mariusz Glebocki wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109891/
> -----------------------------------------------------------
> 
> (Updated April 7, 2013, 7:45 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Add customizable display's contents margins
>     
> Minor changes include possibility of centering the contents on the display, cleaner terminal's contents size and position related code (without magic numbers), better handling of a mouse over effect on links.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 30d72e5 
>   src/EditProfileDialog.cpp 74b0237 
>   src/EditProfileDialog.ui 592370a 
>   src/Profile.h fea0d73 
>   src/Profile.cpp 4995d90 
>   src/TerminalDisplay.h 1747f1b 
>   src/TerminalDisplay.cpp d14daba 
>   src/ViewManager.cpp 4071b8b 
> 
> Diff: http://git.reviewboard.kde.org/r/109891/diff/
> 
> 
> Testing
> -------
> 
> Changing each margin size and toggling the contents centering option, then:
> * resizing the window
> * moving/hiding/scrolling the scrollbar
> * selecting a text
> * moving the cursor over links
> 
> 
> Thanks,
> 
> Mariusz Glebocki
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20130417/3ff1b2c8/attachment.html>