<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109891/">http://git.reviewboard.kde.org/r/109891/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 9th, 2013, 4:25 p.m. CEST, <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the code - I'll need to test the margin portion. I think the leaveEvent should have been a separate review - that looks good.
Is there any reason someone would want a non-uniform margins? Perhaps just 1 option for all 4 sides? And is there any reason to not center the terminal?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Is there any reason someone would want a non-uniform margins? Perhaps just 1 option for all 4 sides?
I'm going to implement a shadow effect for terminal contents, so the use case was terminal embedded in a desktop, with transparent background and shadow with an offset, where margins are used to prevent shadow clipping. On the other hand, it is possible with uniform margins too.
> is there any reason to not center the terminal?
Only one - during window resizing, when the lines or columns count change, the contents image jumps a bit. Someone may not like it, so I just added option to use the old top-left alignment. Another solution is to center the image after some time (like terminal size information hiding).
Anyway, I'm attaching a patch with one parameter for all margins.</pre>
<br />
<p>- Mariusz</p>
<br />
<p>On April 7th, 2013, 7:45 a.m. CEST, Mariusz Glebocki wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Mariusz Glebocki.</div>
<p style="color: grey;"><i>Updated April 7, 2013, 7:45 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add customizable display's contents margins
Minor changes include possibility of centering the contents on the display, cleaner terminal's contents size and position related code (without magic numbers), better handling of a mouse over effect on links.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Changing each margin size and toggling the contents centering option, then:
* resizing the window
* moving/hiding/scrolling the scrollbar
* selecting a text
* moving the cursor over links</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(30d72e5)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(74b0237)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(592370a)</span></li>
<li>src/Profile.h <span style="color: grey">(fea0d73)</span></li>
<li>src/Profile.cpp <span style="color: grey">(4995d90)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(1747f1b)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(d14daba)</span></li>
<li>src/ViewManager.cpp <span style="color: grey">(4071b8b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109891/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>