[Konsole-devel] Review Request: Don't call updateWebSearchMenu from selectionChanged

[Kurt Hindenburg]

Do want this in for 4.10?  If so it has to be done now.
Kurt
 On Nov 30, 2012 10:08 AM, "Jekyll Wu" <adaptee at gmail.com> wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107511/
>
> Ship it!
>
> Can't recall the exact reason why I wrote it that way. I remember something didn't work without that extra call. But it seems not true now.
>
>
> - Jekyll
>
> On November 29th, 2012, 12:33 p.m., Dawit Alemayehu wrote:
>   Review request for Konsole.
> By Dawit Alemayehu.
>
> *Updated Nov. 29, 2012, 12:33 p.m.*
> Description
>
> Don't call updateWebSearchMenu from selectionChanged since updateWebSearchMenu is called right before the context menu is shown. Filtering URIs becomes a very expensive operation if it is done while the user it selecting text (read: many times in a row) and causes issues like those mentioned in the aforementioned bug report.
>
>   *Bugs: * 307973 <http://bugs.kde.org/show_bug.cgi?id=307973>
> Diffs
>
>    - src/SessionController.cpp (036bd37)
>
> View Diff <http://git.reviewboard.kde.org/r/107511/diff/>
>
> _______________________________________________
> konsole-devel mailing list
> konsole-devel at kde.org
> https://mail.kde.org/mailman/listinfo/konsole-devel
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121130/4c20a53b/attachment.html>