[Konsole-devel] Review Request: Don't call updateWebSearchMenu from selectionChanged
kurt.hindenburg at gmail.com
Fri Nov 30 21:05:11 UTC 2012
Do want this in for 4.10? If so it has to be done now.
On Nov 30, 2012 10:08 AM, "Jekyll Wu" <adaptee at gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
> Ship it!
> Can't recall the exact reason why I wrote it that way. I remember something didn't work without that extra call. But it seems not true now.
> - Jekyll
> On November 29th, 2012, 12:33 p.m., Dawit Alemayehu wrote:
> Review request for Konsole.
> By Dawit Alemayehu.
> *Updated Nov. 29, 2012, 12:33 p.m.*
> Don't call updateWebSearchMenu from selectionChanged since updateWebSearchMenu is called right before the context menu is shown. Filtering URIs becomes a very expensive operation if it is done while the user it selecting text (read: many times in a row) and causes issues like those mentioned in the aforementioned bug report.
> *Bugs: * 307973 <http://bugs.kde.org/show_bug.cgi?id=307973>
> - src/SessionController.cpp (036bd37)
> View Diff <http://git.reviewboard.kde.org/r/107511/diff/>
> konsole-devel mailing list
> konsole-devel at kde.org
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the konsole-devel