<p dir="ltr">Do want this in for 4.10? If so it has to be done now.<br>
Kurt<br>
</p>
<div class="gmail_quote">On Nov 30, 2012 10:08 AM, "Jekyll Wu" <<a href="mailto:adaptee@gmail.com">adaptee@gmail.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border:1px #c9c399 solid">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107511/" target="_blank">http://git.reviewboard.kde.org/r/107511/</a>
</td>
</tr>
</table>
<br>
<p>Ship it!</p>
<pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Can't recall the exact reason why I wrote it that way. I remember something didn't work without that extra call. But it seems not true now.
</pre>
<br>
<p>- Jekyll</p>
<br>
<p>On November 29th, 2012, 12:33 p.m., Dawit Alemayehu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image:url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png');background-repeat:repeat-x;border:1px black solid">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Dawit Alemayehu.</div>
<p style="color:grey"><i>Updated Nov. 29, 2012, 12:33 p.m.</i></p>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border:1px solid #b8b5a0">
<tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Don't call updateWebSearchMenu from selectionChanged since updateWebSearchMenu is called right before the context menu is shown. Filtering URIs becomes a very expensive operation if it is done while the user it selecting text (read: many times in a row) and causes issues like those mentioned in the aforementioned bug report.</pre>
</td>
</tr>
</table>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=307973" target="_blank">307973</a>
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/SessionController.cpp <span style="color:grey">(036bd37)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107511/diff/" style="margin-left:3em" target="_blank">View Diff</a></p>
</td>
</tr>
</table>
</div>
</div>
<br>_______________________________________________<br>
konsole-devel mailing list<br>
<a href="mailto:konsole-devel@kde.org">konsole-devel@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/konsole-devel" target="_blank">https://mail.kde.org/mailman/listinfo/konsole-devel</a><br>
<br></blockquote></div>