[Konsole-devel] Review Request: Do not always move the cursor to the end when editing keybinding description

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107287/#review21958
-----------------------------------------------------------


This review has been submitted with commit c1514e143b237b3912c6e7c392d62ae1492ae8b2 by Jekyll Wu to branch KDE/4.9.

- Commit Hook


On Nov. 10, 2012, 11:27 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107287/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2012, 11:27 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> When editing the keybinding description in the keybinding editor, it always move the cursor to the end of line every time a key is pressed, which is caused by calling `setText` when handling the `textChanged` signal.
> This patch add a new private slot to update translator's description without refreshing the KLineEdit, therefore not moving the cursor.
> 
> 
> Diffs
> -----
> 
>   src/KeyBindingEditor.h f66bb43 
>   src/KeyBindingEditor.cpp ec2b0c3 
> 
> Diff: http://git.reviewboard.kde.org/r/107287/diff/
> 
> 
> Testing
> -------
> 
> Compiled and installed.
> 
> Edit the description in the keybinding editor, the description elsewhere (main setup window and keytab file on disk) is updated correctly and the cursor remain where it should be.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20121114/9cebc78c/attachment.html>