<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107287/">http://git.reviewboard.kde.org/r/107287/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit c1514e143b237b3912c6e7c392d62ae1492ae8b2 by Jekyll Wu to branch KDE/4.9.</pre>
<br />
<p>- Commit</p>
<br />
<p>On November 10th, 2012, 11:27 p.m., Yichao Yu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Yichao Yu.</div>
<p style="color: grey;"><i>Updated Nov. 10, 2012, 11:27 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When editing the keybinding description in the keybinding editor, it always move the cursor to the end of line every time a key is pressed, which is caused by calling `setText` when handling the `textChanged` signal.
This patch add a new private slot to update translator's description without refreshing the KLineEdit, therefore not moving the cursor.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled and installed.
Edit the description in the keybinding editor, the description elsewhere (main setup window and keytab file on disk) is updated correctly and the cursor remain where it should be.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/KeyBindingEditor.h <span style="color: grey">(f66bb43)</span></li>
<li>src/KeyBindingEditor.cpp <span style="color: grey">(ec2b0c3)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107287/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>