[Konsole-devel] Review Request: konsolepart should emit a signal when the current directory of active session changes

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104372/#review11792
-----------------------------------------------------------


This review has been submitted with commit 675dbcb2fe777b22044510579321148989d29cfb by Jekyll Wu to branch master.

- Commit Hook


On March 23, 2012, 4:57 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104372/
> -----------------------------------------------------------
> 
> (Updated March 23, 2012, 4:57 a.m.)
> 
> 
> Review request for Konsole and Eike Hein.
> 
> 
> Description
> -------
> 
> This simple patch adds and emits one signal : currentDirChanged(const QString& dir).
> 
> 
> It should work. Maybe the signal should be renamed to currentDirectoryChanged ?
> 
> 
> This addresses bug 156919.
>     http://bugs.kde.org/show_bug.cgi?id=156919
> 
> 
> Diffs
> -----
> 
>   src/SessionController.h 3c749b0 
>   src/SessionController.cpp 0ee550d 
>   src/Part.h 31fff53 
>   src/Part.cpp 6767466 
>   src/Session.h abf9529 
>   src/Session.cpp 4ecd2d7 
> 
> Diff: http://git.reviewboard.kde.org/r/104372/diff/
> 
> 
> Testing
> -------
> 
> Use yakuake to connect and test that signal. Seems fine.
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120323/6b4461c3/attachment.html>