<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104372/">http://git.reviewboard.kde.org/r/104372/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 675dbcb2fe777b22044510579321148989d29cfb by Jekyll Wu to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On March 23rd, 2012, 4:57 a.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole and Eike Hein.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated March 23, 2012, 4:57 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This simple patch adds and emits one signal : currentDirChanged(const QString& dir).
It should work. Maybe the signal should be renamed to currentDirectoryChanged ?
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Use yakuake to connect and test that signal. Seems fine.
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=156919">156919</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/SessionController.h <span style="color: grey">(3c749b0)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(0ee550d)</span></li>
<li>src/Part.h <span style="color: grey">(31fff53)</span></li>
<li>src/Part.cpp <span style="color: grey">(6767466)</span></li>
<li>src/Session.h <span style="color: grey">(abf9529)</span></li>
<li>src/Session.cpp <span style="color: grey">(4ecd2d7)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104372/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>