[Konsole-devel] Review Request: replace the font size slider with a numinput

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105796/#review16720
-----------------------------------------------------------


"why fractions were allowed as Konsole has to have integer sizes". 

Yes, fraction is a problem that should be fixed. Actually, it is also possible to force integer using the exising QSlider by calling setSingleStep() with an appropriate value (10 for existing code). But if using KIntNumInput means less and cleaner code, then go ahead.

Another thing is that the existing code sets the minimum font size to 4 in the slider. Do you think that lower limit should be kept in the new code? What about also setting an reasonable upper limit?


- Jekyll Wu


On July 30, 2012, 2:50 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105796/
> -----------------------------------------------------------
> 
> (Updated July 30, 2012, 2:50 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> I'm not sure why a slider was used for the font size. And why fractions were allowed as Konsole has to have integer sizes.
> 
> If we really want a slider, kintnuminput has the option to add it as well.
> 
> I also removed the "size :" from the preview label as I was looking at bko 174998.
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.ui be3e672 
>   src/EditProfileDialog.h 4715ec5 
>   src/EditProfileDialog.cpp 68d5729 
> 
> Diff: http://git.reviewboard.kde.org/r/105796/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120731/f9a91991/attachment.html>