<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105796/">http://git.reviewboard.kde.org/r/105796/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"why fractions were allowed as Konsole has to have integer sizes".
Yes, fraction is a problem that should be fixed. Actually, it is also possible to force integer using the exising QSlider by calling setSingleStep() with an appropriate value (10 for existing code). But if using KIntNumInput means less and cleaner code, then go ahead.
Another thing is that the existing code sets the minimum font size to 4 in the slider. Do you think that lower limit should be kept in the new code? What about also setting an reasonable upper limit?
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On July 30th, 2012, 2:50 p.m., Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated July 30, 2012, 2:50 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not sure why a slider was used for the font size. And why fractions were allowed as Konsole has to have integer sizes.
If we really want a slider, kintnuminput has the option to add it as well.
I also removed the "size :" from the preview label as I was looking at bko 174998.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.ui <span style="color: grey">(be3e672)</span></li>
<li>src/EditProfileDialog.h <span style="color: grey">(4715ec5)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(68d5729)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105796/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>