[Konsole-devel] Review Request: Use 'KColorScheme::PositiveBackground' for a positive search result

[Kurt Hindenburg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105777/#review16620
-----------------------------------------------------------

Ship it!


the actual code looks  OK - try to keep the kdelibs/qt coding style
http://techbase.kde.org/Policies/Kdelibs_Coding_Style
http://qt-project.org/wiki/Qt_Coding_Style

- Kurt Hindenburg


On July 28, 2012, 11:49 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105777/
> -----------------------------------------------------------
> 
> (Updated July 28, 2012, 11:49 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Set '_searchEdit' field background to 'KColorScheme::PositiveBackground' when a search has a positive result.
> 
> 
> This addresses bug 167442.
>     http://bugs.kde.org/show_bug.cgi?id=167442
> 
> 
> Diffs
> -----
> 
>   src/IncrementalSearchBar.h ddd0e6a 
>   src/IncrementalSearchBar.cpp f34f90d 
>   src/SessionController.cpp 2e31b30 
> 
> Diff: http://git.reviewboard.kde.org/r/105777/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> Positive match
>   http://git.reviewboard.kde.org/r/105777/s/649/
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120729/c0b84b42/attachment.html>