[Konsole-devel] Review Request: Use 'KColorScheme::PositiveBackground' for a positive search result

[Francesco Cecconi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105777/
-----------------------------------------------------------

(Updated July 28, 2012, 11:49 p.m.)


Review request for Konsole.


Changes
-------

With the commit cc7af6655625242a4dda2ed5c4c24d26b37f88ea, change

-        searchHistory(_searchToggleAction->isChecked());
+        enableSearchBar(_searchToggleAction->isChecked());

switching tab, the _searchEdit background is not related to previous search. 
Reset background color to 'setStyleSheet(QString())' (white) is the best fix at the moment.


Description
-------

Set '_searchEdit' field background to 'KColorScheme::PositiveBackground' when a search has a positive result.


This addresses bug 167442.
    http://bugs.kde.org/show_bug.cgi?id=167442


Diffs (updated)
-----

  src/IncrementalSearchBar.h ddd0e6a 
  src/IncrementalSearchBar.cpp f34f90d 
  src/SessionController.cpp 2e31b30 

Diff: http://git.reviewboard.kde.org/r/105777/diff/


Testing
-------


Screenshots
-----------

Positive match
  http://git.reviewboard.kde.org/r/105777/s/649/


Thanks,

Francesco Cecconi

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120728/edfe25ac/attachment.html>