[Konsole-devel] Review Request: make find shortcut event consistent with other KDE apps.

[Francesco Cecconi]

> On July 27, 2012, 4:14 a.m., Jekyll Wu wrote:
> > I agree that bug should be fixed for the sake of consistency with other KDE applications.
> > 
> > Besides the inconsistency described in that bug report, there is another more important and underlying inconsistency. The "Find" action in other KDE applications(konqueror,kate,okular, etc) is just a plain action, while in the current konsole it is a toggleable action. The current patch makes the toggleing useless(which introduces another UI bug), so to really fix the inconsistency I think we should first eliminate the underlying "toggle" semantic.
> >

removed toggleable action, now "Find" is a normal KAction.


> On July 27, 2012, 4:14 a.m., Jekyll Wu wrote:
> > src/SessionController.h, line 338
> > <http://git.reviewboard.kde.org/r/105723/diff/1/?file=74749#file74749line338>
> >
> >     Could you try to give it a more explicit name? It is not easy to infer what "Close" button it refers to without reading the code related with that flag.
> >     
> >     Or maybe this flag is not needed if the "Find" action is just a plain action which can not be toggled.

removed, It is not needed anymore.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105723/#review16502
-----------------------------------------------------------


On July 27, 2012, 9:53 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105723/
> -----------------------------------------------------------
> 
> (Updated July 27, 2012, 9:53 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> When search bar is visible, pressing the shortcut (ctrl+alt+f) again set focus to the search box.
> 
> 
> This addresses bug 271668.
>     http://bugs.kde.org/show_bug.cgi?id=271668
> 
> 
> Diffs
> -----
> 
>   src/SessionController.h 1136248 
>   src/SessionController.cpp f90f927 
> 
> Diff: http://git.reviewboard.kde.org/r/105723/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120727/0abdea7f/attachment.html>