[Konsole-devel] Review Request: make find shortcut event consistent with other KDE apps.

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105723/#review16502
-----------------------------------------------------------


I agree that bug should be fixed for the sake of consistency with other KDE applications.

Besides the inconsistency described in that bug report, there is another more important and underlying inconsistency. The "Find" action in other KDE applications(konqueror,kate,okular, etc) is just a plain action, while in the current konsole it is a toggleable action. The current patch makes the toggleing useless(which introduces another UI bug), so to really fix the inconsistency I think we should first eliminate the underlying "toggle" semantic.



src/SessionController.h
<http://git.reviewboard.kde.org/r/105723/#comment12866>

    Could you try to give it a more explicit name? It is not easy to infer what "Close" button it refers to without reading the code related with that flag.
    
    Or maybe this flag is not needed if the "Find" action is just a plain action which can not be toggled.


- Jekyll Wu


On July 25, 2012, 11:10 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105723/
> -----------------------------------------------------------
> 
> (Updated July 25, 2012, 11:10 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> When search bar is visible, pressing the shortcut (ctrl+alt+f) again set focus to the search box.
> 
> 
> This addresses bug 271668.
>     http://bugs.kde.org/show_bug.cgi?id=271668
> 
> 
> Diffs
> -----
> 
>   src/SessionController.h 1136248 
>   src/SessionController.cpp f90f927 
> 
> Diff: http://git.reviewboard.kde.org/r/105723/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120727/3a70e602/attachment.html>