[Konsole-devel] Review Request: fix untranslated property update.

[Francesco Cecconi]

> On July 24, 2012, 3 a.m., Jekyll Wu wrote:
> > The patch works fine. For consistency, it is better to modify ManageProfilesDialog::itemDataChanged() and ManageProfilesDialog::createProfile() to also update the "UntranslatedName" property in an explicit way.  
> > 
> > I have been thinking of this "UntranslatedName" problem for some time. I would say I don't like this property introduced by myself :) . Now we have three related names to consider: Name, UntranslatedName and the filename on the disk. That makes the existing messy situation of how to identify a profile even worse.
> > 
> > Whatever, please commit it . And congratulations to Francesco for getting your developer account.
> > 
> > 
> > 
> >

> The patch works fine. For consistency, it is better to modify ManageProfilesDialog::itemDataChanged() and
> ManageProfilesDialog::createProfile() to also update the "UntranslatedName" property in an explicit way. 

Done.

> Whatever, please commit it . And congratulations to Francesco for getting your developer account.

Many Thanks Jekyll and this evening I'll commit the patch. :)


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105648/#review16284
-----------------------------------------------------------


On July 24, 2012, 10:19 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105648/
> -----------------------------------------------------------
> 
> (Updated July 24, 2012, 10:19 a.m.)
> 
> 
> Review request for Konsole and Jekyll Wu.
> 
> 
> Description
> -------
> 
> update the untranslated property when a new profile is created or updated.
> 
> 
> This addresses bug 303354.
>     http://bugs.kde.org/show_bug.cgi?id=303354
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.cpp 5b74c85 
>   src/ManageProfilesDialog.cpp afc6c4a 
> 
> Diff: http://git.reviewboard.kde.org/r/105648/diff/
> 
> 
> Testing
> -------
> 
> tested with bko
> 
> PS: now I have a developer account for commit.
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120724/8a63509a/attachment.html>