[Konsole-devel] Review Request: fix untranslated property update.

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105648/#review16284
-----------------------------------------------------------

Ship it!


The patch works fine. For consistency, it is better to modify ManageProfilesDialog::itemDataChanged() and ManageProfilesDialog::createProfile() to also update the "UntranslatedName" property in an explicit way.  

I have been thinking of this "UntranslatedName" problem for some time. I would say I don't like this property introduced by myself :) . Now we have three related names to consider: Name, UntranslatedName and the filename on the disk. That makes the existing messy situation of how to identify a profile even worse.

Whatever, please commit it . And congratulations to Francesco for getting your developer account.





- Jekyll Wu


On July 23, 2012, 1:54 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105648/
> -----------------------------------------------------------
> 
> (Updated July 23, 2012, 1:54 p.m.)
> 
> 
> Review request for Konsole and Jekyll Wu.
> 
> 
> Description
> -------
> 
> update the untranslated property when a new profile is created or updated.
> 
> 
> This addresses bug 303354.
>     http://bugs.kde.org/show_bug.cgi?id=303354
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.cpp 5b74c85 
> 
> Diff: http://git.reviewboard.kde.org/r/105648/diff/
> 
> 
> Testing
> -------
> 
> tested with bko
> 
> PS: now I have a developer account for commit.
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120724/5566cf06/attachment.html>