[Konsole-devel] Review Request: Check processes names that are running when exiting to determine if ask user if continue to quit

[Kurt Hindenburg]

> On Jan. 29, 2012, 11:37 a.m., Jekyll Wu wrote:
> > src/MainWindow.cpp, line 420
> > <http://git.reviewboard.kde.org/r/103814/diff/1/?file=48082#file48082line420>
> >
> >     I'm a little confused here. 
> >     
> >     According to this logic, if I have three zsh session running(no foreground task), there will be no warning when I close that Konsole window?
> >     
> >
> 
> Kurt Hindenburg wrote:
>     In the GUI settings, the user could add any program they wanted to be checked.  I don't think checking the shells would be necessary.  THere also could be a checkbox if the users wanted warned when 2+ tabs are open (as is the case now).
>
> 
> Jekyll Wu wrote:
>     I tend to disagree. A shell session currently without foreground process running is almost as important as  a shell session with foreground process(vim/mc/cp/mv) running, because its scrollback is valuable and unrecoverable once it is lost due to carelessly closing the whole window.
>     
>     I think the logic of queryClose() should stay simple: 
>     
>     1). Always give warning when there are multiple sessions running in current window.
>     2). And (optionllly), give warning when there is only one session running but the initial process in that session happens to be something important to the users(configured by users in the GUI) . I think that is what bko 134581 is requesting for.
>     
>     My general thought is we can add support for case 2), but case 1) should not be changed.

OK, so we differ.  This dialog is when the user selected File->Quit, clicks on 'X' in window and now logs out (including shutting down/rebooting).
In my opinion, I only want notified if I have certain programs running (such as vim, ssh...).  
Since the user is the one asking for Konsole to quit, it seems reasonable to quit silently unless they've asked for a dialog in certain cases (2+ sessions, programs running,etc).


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103814/#review10189
-----------------------------------------------------------


On Jan. 28, 2012, 7:42 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103814/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2012, 7:42 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This is a small sample of code that checks the process names w/ a list (that would be user changeable).  Feedback welcomed before I code more of it.
> 
> 1. Should this be profile specify or Konsole?  I would prefer Konsole.
> 2. This won't work on systems where the process name can't be determined (MacOSX, likely other non-Linux OSes).
> 
> bko 134581 may be related
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 9e1606d 
> 
> Diff: http://git.reviewboard.kde.org/r/103814/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120129/43271006/attachment.html>