<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103814/">http://git.reviewboard.kde.org/r/103814/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 29th, 2012, 11:37 a.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103814/diff/1/?file=48082#file48082line420" style="color: black; font-weight: bold; text-decoration: underline;">src/MainWindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MainWindow::newWindow()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">420</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span><span class="o">!</span><span class="n">session</span><span class="o">-></span><span class="n">isForegroundProcessActive</span><span class="p">())</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm a little confused here.
According to this logic, if I have three zsh session running(no foreground task), there will be no warning when I close that Konsole window?
</pre>
</blockquote>
<p>On January 29th, 2012, 2:25 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In the GUI settings, the user could add any program they wanted to be checked. I don't think checking the shells would be necessary. THere also could be a checkbox if the users wanted warned when 2+ tabs are open (as is the case now).
</pre>
</blockquote>
<p>On January 29th, 2012, 3:25 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tend to disagree. A shell session currently without foreground process running is almost as important as a shell session with foreground process(vim/mc/cp/mv) running, because its scrollback is valuable and unrecoverable once it is lost due to carelessly closing the whole window.
I think the logic of queryClose() should stay simple:
1). Always give warning when there are multiple sessions running in current window.
2). And (optionllly), give warning when there is only one session running but the initial process in that session happens to be something important to the users(configured by users in the GUI) . I think that is what bko 134581 is requesting for.
My general thought is we can add support for case 2), but case 1) should not be changed.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">OK, so we differ. This dialog is when the user selected File->Quit, clicks on 'X' in window and now logs out (including shutting down/rebooting).
In my opinion, I only want notified if I have certain programs running (such as vim, ssh...).
Since the user is the one asking for Konsole to quit, it seems reasonable to quit silently unless they've asked for a dialog in certain cases (2+ sessions, programs running,etc).</pre>
<br />
<p>- Kurt</p>
<br />
<p>On January 28th, 2012, 7:42 p.m., Kurt Hindenburg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Kurt Hindenburg.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2012, 7:42 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a small sample of code that checks the process names w/ a list (that would be user changeable). Feedback welcomed before I code more of it.
1. Should this be profile specify or Konsole? I would prefer Konsole.
2. This won't work on systems where the process name can't be determined (MacOSX, likely other non-Linux OSes).
bko 134581 may be related</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/MainWindow.cpp <span style="color: grey">(9e1606d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103814/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>