[Konsole-devel] Review Request: Check processes names that are running when exiting to determine if ask user if continue to quit

[Kurt Hindenburg]

> On Jan. 29, 2012, 11:37 a.m., Jekyll Wu wrote:
> > src/MainWindow.cpp, line 412
> > <http://git.reviewboard.kde.org/r/103814/diff/1/?file=48082#file48082line412>
> >
> >     This list contains all sessions ,including sessions running in other Konsole windows. It is ok for queryClose(), a per window method, to check sessions from other windows?

The code would have to be check for only the current window's sessions.


> On Jan. 29, 2012, 11:37 a.m., Jekyll Wu wrote:
> > src/MainWindow.cpp, line 420
> > <http://git.reviewboard.kde.org/r/103814/diff/1/?file=48082#file48082line420>
> >
> >     I'm a little confused here. 
> >     
> >     According to this logic, if I have three zsh session running(no foreground task), there will be no warning when I close that Konsole window?
> >     
> >

In the GUI settings, the user could add any program they wanted to be checked.  I don't think checking the shells would be necessary.  THere also could be a checkbox if the users wanted warned when 2+ tabs are open (as is the case now).


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103814/#review10189
-----------------------------------------------------------


On Jan. 28, 2012, 7:42 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103814/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2012, 7:42 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This is a small sample of code that checks the process names w/ a list (that would be user changeable).  Feedback welcomed before I code more of it.
> 
> 1. Should this be profile specify or Konsole?  I would prefer Konsole.
> 2. This won't work on systems where the process name can't be determined (MacOSX, likely other non-Linux OSes).
> 
> bko 134581 may be related
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 9e1606d 
> 
> Diff: http://git.reviewboard.kde.org/r/103814/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120129/5cb8cda3/attachment.html>