[Konsole-devel] Review Request: Check processes names that are running when exiting to determine if ask user if continue to quit

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103814/#review10189
-----------------------------------------------------------



src/MainWindow.cpp
<http://git.reviewboard.kde.org/r/103814/#comment8383>

    This list contains all sessions ,including sessions running in other Konsole windows. It is ok for queryClose(), a per window method, to check sessions from other windows?



src/MainWindow.cpp
<http://git.reviewboard.kde.org/r/103814/#comment8384>

    I'm a little confused here. 
    
    According to this logic, if I have three zsh session running(no foreground task), there will be no warning when I close that Konsole window?
    
    



src/MainWindow.cpp
<http://git.reviewboard.kde.org/r/103814/#comment8385>

    I think bko 134581 is asking for extra warning for running vim or top session directly, not a vim or top running in a zsh session.


- Jekyll Wu


On Jan. 28, 2012, 7:42 p.m., Kurt Hindenburg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103814/
> -----------------------------------------------------------
> 
> (Updated Jan. 28, 2012, 7:42 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This is a small sample of code that checks the process names w/ a list (that would be user changeable).  Feedback welcomed before I code more of it.
> 
> 1. Should this be profile specify or Konsole?  I would prefer Konsole.
> 2. This won't work on systems where the process name can't be determined (MacOSX, likely other non-Linux OSes).
> 
> bko 134581 may be related
> 
> 
> Diffs
> -----
> 
>   src/MainWindow.cpp 9e1606d 
> 
> Diff: http://git.reviewboard.kde.org/r/103814/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kurt Hindenburg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120129/44974395/attachment.html>