[Konsole-devel] Review Request: Make Shell.profile minimal

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103668/#review9711
-----------------------------------------------------------


This review has been submitted with commit f17eac9651f027c86c53f5a3e8a7f912deb8c94f by Jekyll Wu to branch master.

- Commit Hook


On Jan. 10, 2012, 6:42 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103668/
> -----------------------------------------------------------
> 
> (Updated Jan. 10, 2012, 6:42 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> Currently, Shell.profile contains some entries which are either useless or duplicates: 
> 
> 1. 'ScrollMode' and 'ScrollLineCount' are outdated and useless.
> 
> 2. 'Icon', 'ColorScheme', 'LocalTabTitleFormat' etc are the duplicates of the one in 'fallback' profile. Duplicating them in Shell.profile only increases the maintenance burden without providing any benefit.
> 
> So I would suggest to remove those entries, and only keep 'Name' and 'Comment' entries. Actually, the 'Comment' entries may also be removed, but since keeping or removing it does not influence the maintenance burden, we can keep it. Maybe those 'Comment' entries are really helpful to translators.
> 
> And, maybe we should add one 'Parent' entry, thus marking the 'fallback' profile as its parent in an explicit way? 
> 
> 
> Diffs
> -----
> 
>   data/profiles/Shell.profile bc7faf0 
> 
> Diff: http://git.reviewboard.kde.org/r/103668/diff/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120110/48aa0888/attachment.html>