[Konsole-devel] [Bug 256353] Selecting text by triple click and scolling up causes only the visible contents to be selected

Shlomi Fish shlomif at shlomifish.org
Tue Jan 10 08:58:11 UTC 2012


https://bugs.kde.org/show_bug.cgi?id=256353





--- Comment #2 from Shlomi Fish <shlomif shlomifish org>  2012-01-10 08:58:11 ---
Created an attachment (id=67643)
 --> (http://bugs.kde.org/attachment.cgi?id=67643)
A tentative patch that seems to fix the problem here.

This is a tentative fix to this bug. It is tentative because it contains some
code I added in order to debug this. Nevertheless, the fix is only in the
src/ScreenWindow.cpp and is toggled by the "#define BUG256353_FIX".

What happens there is that the original authors used qMin(...) to limit the
code based on the current window's boundaries. Perhaps we need one qMin() and
one qMax(), but, from my understanding, it could be that end < start and so
it's hard to know when to use each one. I simply removed the boundings and
everything seems to be OK.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the konsole-devel mailing list