[Konsole-devel] Review Request: use KMessageWidget in place of Konsole::WarningBox
Jekyll Wu
adaptee at gmail.com
Thu Feb 23 19:10:46 UTC 2012
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104053/
-----------------------------------------------------------
Review request for Konsole.
Description
-------
See point 3 in http://lists.kde.org/?l=konsole-devel&m=133002045514264&w=2
The patch still needs more polishment(removing unused staff, etc), but the important thing is all done.
Diffs
-----
src/ColorSchemeEditor.cpp 796a22b
src/ColorSchemeEditor.ui 042213f
src/EditProfileDialog.cpp 39c630a
src/EditProfileDialog.ui a9c600c
Diff: http://git.reviewboard.kde.org/r/104053/diff/
Testing
-------
Screenshots
-----------
warning for empty profile name
http://git.reviewboard.kde.org/r/104053/s/440/
warning for transparency
http://git.reviewboard.kde.org/r/104053/s/441/
warning for transparency again
http://git.reviewboard.kde.org/r/104053/s/442/
Thanks,
Jekyll Wu
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120223/48af9c83/attachment.html>
More information about the konsole-devel
mailing list