[Konsole-devel] Review Request: Accessibility for Konsole

[Kurt Hindenburg]

> On Jan. 27, 2012, 5:43 p.m., Frederik Gladhorn wrote:
> > One question I have, do TerminalDisplay::screenWindow() and ScreenWindow::screen() always return a valid object or can they be 0?
> > Are there easier ways to get at the information? I don't know the Konsole code, so I'm happy about advise.
> 
> Kurt Hindenburg wrote:
>     I would suggest checking screenWindow.  Why use #ifndef QT_NO_ACCESSIBILITY instead of #ifdef QT_ACCESSIBILITY?  Is there a reasonable simple way to test this?
>     
>
> 
> Frederik Gladhorn wrote:
>     I added a check for screenWindow, thanks!
>     The #ifndef QT_NO_ACCESSIBILITY is the standard way in Qt to disable these additional build-time features.

Just to confirm, this works for you in your testing?  Also, is there a simple way of testing this?


- Kurt


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103805/#review10157
-----------------------------------------------------------


On Feb. 11, 2012, 7:48 p.m., Frederik Gladhorn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103805/
> -----------------------------------------------------------
> 
> (Updated Feb. 11, 2012, 7:48 p.m.)
> 
> 
> Review request for Konsole, Jeremy Paul Whiting, José Millán Soto, and Sebastian Sauer.
> 
> 
> Description
> -------
> 
> Add accessible interface to Konsole's display window.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt e792d5e 
>   src/Screen.h 330f087 
>   src/Screen.cpp 3d8944c 
>   src/TerminalDisplay.h 0ea9669 
>   src/TerminalDisplay.cpp 4c2c80f 
>   src/TerminalDisplayAccessible.h PRE-CREATION 
>   src/TerminalDisplayAccessible.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103805/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Frederik Gladhorn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120218/133b08f4/attachment.html>