<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103805/">http://git.reviewboard.kde.org/r/103805/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 27th, 2012, 5:43 p.m., <b>Frederik Gladhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One question I have, do TerminalDisplay::screenWindow() and ScreenWindow::screen() always return a valid object or can they be 0?
Are there easier ways to get at the information? I don't know the Konsole code, so I'm happy about advise.</pre>
</blockquote>
<p>On February 11th, 2012, 4:34 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would suggest checking screenWindow. Why use #ifndef QT_NO_ACCESSIBILITY instead of #ifdef QT_ACCESSIBILITY? Is there a reasonable simple way to test this?
</pre>
</blockquote>
<p>On February 11th, 2012, 7:45 p.m., <b>Frederik Gladhorn</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I added a check for screenWindow, thanks!
The #ifndef QT_NO_ACCESSIBILITY is the standard way in Qt to disable these additional build-time features.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Just to confirm, this works for you in your testing? Also, is there a simple way of testing this?</pre>
<br />
<p>- Kurt</p>
<br />
<p>On February 11th, 2012, 7:48 p.m., Frederik Gladhorn wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole, Jeremy Paul Whiting, José Millán Soto, and Sebastian Sauer.</div>
<div>By Frederik Gladhorn.</div>
<p style="color: grey;"><i>Updated Feb. 11, 2012, 7:48 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add accessible interface to Konsole's display window.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(e792d5e)</span></li>
<li>src/Screen.h <span style="color: grey">(330f087)</span></li>
<li>src/Screen.cpp <span style="color: grey">(3d8944c)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(0ea9669)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(4c2c80f)</span></li>
<li>src/TerminalDisplayAccessible.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/TerminalDisplayAccessible.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103805/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>