[Konsole-devel] Review Request: Finer grained choices for X Selection/Clipboard

[Jekyll Wu]

> On Feb. 12, 2012, 6:45 p.m., Jekyll Wu wrote:
> > I haven't read the code in detail. Just apply the patch, compile and play with it for a while.
> > 
> > I'm still in doubt with this feature, especially after seeing that now we have two choices for auto-copying-selected-text-to and two choice for middle-click-pasting-from. 
> > 
> > For the auto-copying-selected-text-to, here are the possible combinations in my observation:
> > 
> >   * selection (Do we need this when that is already the well-known convention?)
> >   * selection + clipboard (make sense accroding to the feature report )
> >   * clipboard (I don't follow it: automatically copy selected text into clipboard without touching selection?)  
> > 
> > So I think one checkbox "automaticaly copy selected text into clipboard" is enough.
> > 
> > For the middle-click-pasting-from, if selection and clipboard and in sync when the above checkbox is enabled, do we need the choice again here?
> > 
> > And it is better to attach a screenshot since the patch introduce non-trivial UI changes.
> > 
> > Just my 2 cents. Kurt has the final say. And we still have enough time to decide to accept or reject it before next major release.
> > 
> > 
> > 
> > 
> >
> 
> Adam Batkin wrote:
>     Good points:
>     
>     1) If you think it's better to just have one check box, which will have it also copy to the X Clipboard, that's fine and makes sense, and if we all agree, I can adjust the patch immediately
>     
>     2) As for the pasting option, I guess it's actually a slightly different use case. You are right that if selection within konsole copies to both X Selection and Clipboard, then for middle-click-pasting, it doesn't matter whether it comes from the X Selection or Clipboard. BUT... when coming from other applications (where X Selection and Clipboard may not be in sync) it does make a difference.
>     
>     In general, I never like to think about the X Selection. It's too "implicit" whereas the Clipboard requires me to be more "explicit". There are lots of times when I select text, because I need to perform some operation on the selected text, but I still need (and remember) whatever was in the clipboard. What this means is that I will always "know" what is in the X Clipboard, but I rarely know what is in the X Selection. Which is why I want middle-click-paste in Konsole to paste from the Clipboard.
>     
>     And yeah, I know I'm slightly hypocritical because I want konsole to copy text to the clipboard "implicitly" every time I select something, even though nothing else does that. But then again, I spend most of my day in konsole and the only reason I would ever select text there is to get it into the clipboard (as opposed to other apps where I often have other reasons for selecting text).

Thanks for the quick reply.

Yeah, for the auto-copying-selected-text choices, please change it into checkbox.

I now see the point for the middle-click-pasting choices.  So keep them for now :)


- Jekyll


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103861/#review10556
-----------------------------------------------------------


On Feb. 12, 2012, 7:14 p.m., Adam Batkin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103861/
> -----------------------------------------------------------
> 
> (Updated Feb. 12, 2012, 7:14 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> * Creates new "Mouse" Profile Options tab with all of the mouse stuff
> * Selected text can now go to X Selection AND/OR Clipboard (instead of OR)
> * Middle-Mouse clicks can paste from X Selection or Profile
> 
> The whole rationale here is that I almost never care about the X Selection (and
> I'm probably not alone). And in the few cases where I DO care, well, that's my
> problem. So this patch leaves all of the defaults as-is (no one will notice a
> change) but for people for whom it makes a difference, now they can control
> what is going on.
> 
> 
> This addresses bug 183490.
>     http://bugs.kde.org/show_bug.cgi?id=183490
> 
> 
> Diffs
> -----
> 
>   src/EditProfileDialog.h 6c5f91d 
>   src/EditProfileDialog.cpp e9086e0 
>   src/EditProfileDialog.ui a9c600c 
>   src/Profile.h d78e723 
>   src/Profile.cpp d617e9e 
>   src/SessionController.h 7738e45 
>   src/SessionController.cpp 23b307c 
>   src/TerminalDisplay.h 475fa53 
>   src/TerminalDisplay.cpp da2fb38 
> 
> Diff: http://git.reviewboard.kde.org/r/103861/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> konsole "Mouse" profile configuration tab
>   http://git.reviewboard.kde.org/r/103861/s/430/
> 
> 
> Thanks,
> 
> Adam Batkin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120212/e3acef98/attachment.html>