<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103861/">http://git.reviewboard.kde.org/r/103861/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 12th, 2012, 6:45 p.m., <b>Jekyll Wu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I haven't read the code in detail. Just apply the patch, compile and play with it for a while.
I'm still in doubt with this feature, especially after seeing that now we have two choices for auto-copying-selected-text-to and two choice for middle-click-pasting-from.
For the auto-copying-selected-text-to, here are the possible combinations in my observation:
* selection (Do we need this when that is already the well-known convention?)
* selection + clipboard (make sense accroding to the feature report )
* clipboard (I don't follow it: automatically copy selected text into clipboard without touching selection?)
So I think one checkbox "automaticaly copy selected text into clipboard" is enough.
For the middle-click-pasting-from, if selection and clipboard and in sync when the above checkbox is enabled, do we need the choice again here?
And it is better to attach a screenshot since the patch introduce non-trivial UI changes.
Just my 2 cents. Kurt has the final say. And we still have enough time to decide to accept or reject it before next major release.
</pre>
</blockquote>
<p>On February 12th, 2012, 7:11 p.m., <b>Adam Batkin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good points:
1) If you think it's better to just have one check box, which will have it also copy to the X Clipboard, that's fine and makes sense, and if we all agree, I can adjust the patch immediately
2) As for the pasting option, I guess it's actually a slightly different use case. You are right that if selection within konsole copies to both X Selection and Clipboard, then for middle-click-pasting, it doesn't matter whether it comes from the X Selection or Clipboard. BUT... when coming from other applications (where X Selection and Clipboard may not be in sync) it does make a difference.
In general, I never like to think about the X Selection. It's too "implicit" whereas the Clipboard requires me to be more "explicit". There are lots of times when I select text, because I need to perform some operation on the selected text, but I still need (and remember) whatever was in the clipboard. What this means is that I will always "know" what is in the X Clipboard, but I rarely know what is in the X Selection. Which is why I want middle-click-paste in Konsole to paste from the Clipboard.
And yeah, I know I'm slightly hypocritical because I want konsole to copy text to the clipboard "implicitly" every time I select something, even though nothing else does that. But then again, I spend most of my day in konsole and the only reason I would ever select text there is to get it into the clipboard (as opposed to other apps where I often have other reasons for selecting text).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for the quick reply.
Yeah, for the auto-copying-selected-text choices, please change it into checkbox.
I now see the point for the middle-click-pasting choices. So keep them for now :)
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On February 12th, 2012, 7:14 p.m., Adam Batkin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Adam Batkin.</div>
<p style="color: grey;"><i>Updated Feb. 12, 2012, 7:14 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">* Creates new "Mouse" Profile Options tab with all of the mouse stuff
* Selected text can now go to X Selection AND/OR Clipboard (instead of OR)
* Middle-Mouse clicks can paste from X Selection or Profile
The whole rationale here is that I almost never care about the X Selection (and
I'm probably not alone). And in the few cases where I DO care, well, that's my
problem. So this patch leaves all of the defaults as-is (no one will notice a
change) but for people for whom it makes a difference, now they can control
what is going on.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=183490">183490</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/EditProfileDialog.h <span style="color: grey">(6c5f91d)</span></li>
<li>src/EditProfileDialog.cpp <span style="color: grey">(e9086e0)</span></li>
<li>src/EditProfileDialog.ui <span style="color: grey">(a9c600c)</span></li>
<li>src/Profile.h <span style="color: grey">(d78e723)</span></li>
<li>src/Profile.cpp <span style="color: grey">(d617e9e)</span></li>
<li>src/SessionController.h <span style="color: grey">(7738e45)</span></li>
<li>src/SessionController.cpp <span style="color: grey">(23b307c)</span></li>
<li>src/TerminalDisplay.h <span style="color: grey">(475fa53)</span></li>
<li>src/TerminalDisplay.cpp <span style="color: grey">(da2fb38)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103861/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103861/s/430/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/02/12/konsole-selection-configuration_400x100.png" style="border: 1px black solid;" alt="konsole "Mouse" profile configuration tab" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>