[Konsole-devel] Review Request: Rearrange the 'File' menu

[Jekyll Wu]

> On Feb. 11, 2012, 3:53 p.m., Kurt Hindenburg wrote:
> > Yea I couldn't upload a diff either.  Did you forget to +1 the sessionui.rc version?  It looks fine to me although I'm not sure there needs to be a separator between Close Tab and Close Window.

Oops, I did forget the version +1 for sessionui.rc :(

As for the separator, I will try to remove it.


- Jekyll


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103920/#review10506
-----------------------------------------------------------


On Feb. 10, 2012, 8:06 p.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103920/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2012, 8:06 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> This is kind of a follow up of review #103859.
> 
> There are basically two changes:
> 
> 1). Rename "Quit" into "Close Window", which is more accurate. That action only close current window, not necessarilly quitting the application.
> 
> 2). Move "Close Tab" downwards to be adjacent to "Close Window". Those two actions are conceptually related just like "New Window" and "New Tab".
> 
> 
> I don't know why, but reviewboard just wouldn't let me upload the patch. So I put the change here:
> 
> https://github.com/adaptee/konsole/commit/a7e45130b831a9386ec6195087c52ddf56bbff51
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/103920/diff/
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> File Menu
>   http://git.reviewboard.kde.org/r/103920/s/429/
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120211/c864be39/attachment.html>