<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103920/">http://git.reviewboard.kde.org/r/103920/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 11th, 2012, 3:53 p.m., <b>Kurt Hindenburg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yea I couldn't upload a diff either. Did you forget to +1 the sessionui.rc version? It looks fine to me although I'm not sure there needs to be a separator between Close Tab and Close Window.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oops, I did forget the version +1 for sessionui.rc :(
As for the separator, I will try to remove it.
</pre>
<br />
<p>- Jekyll</p>
<br />
<p>On February 10th, 2012, 8:06 p.m., Jekyll Wu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konsole.</div>
<div>By Jekyll Wu.</div>
<p style="color: grey;"><i>Updated Feb. 10, 2012, 8:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is kind of a follow up of review #103859.
There are basically two changes:
1). Rename "Quit" into "Close Window", which is more accurate. That action only close current window, not necessarilly quitting the application.
2). Move "Close Tab" downwards to be adjacent to "Close Window". Those two actions are conceptually related just like "New Window" and "New Tab".
I don't know why, but reviewboard just wouldn't let me upload the patch. So I put the change here:
https://github.com/adaptee/konsole/commit/a7e45130b831a9386ec6195087c52ddf56bbff51</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103920/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103920/s/429/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2012/02/10/file-menu_400x100.png" style="border: 1px black solid;" alt="File Menu" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>