[Konsole-devel] Review Request: Add 'shift+return' pressed event for search 'lineEdit'

Francesco Cecconi francesco.cecconi at gmail.com
Wed Aug 8 14:50:27 UTC 2012



> On Aug. 8, 2012, 1:43 p.m., Kurt Hindenburg wrote:
> > src/IncrementalSearchBar.cpp, line 163
> > <http://git.reviewboard.kde.org/r/105925/diff/1/?file=76597#file76597line163>
> >
> >     I'd prefer if you used () around expressions to make it easier to read.

I have removed bitwise operator.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105925/#review17107
-----------------------------------------------------------


On Aug. 8, 2012, 2:19 p.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105925/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 2:19 p.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> When search 'lineEdit' is focused, press 'shift+return' key, highlight the previous search result.
> 
> 
> Diffs
> -----
> 
>   src/IncrementalSearchBar.h 94f19fe 
>   src/IncrementalSearchBar.cpp dc6d7b8 
>   src/SessionController.cpp 095ac8d 
> 
> Diff: http://git.reviewboard.kde.org/r/105925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120808/7087da3d/attachment.html>


More information about the konsole-devel mailing list