[Konsole-devel] Review Request: Add 'shift+return' pressed event for search 'lineEdit'

Kurt Hindenburg kurt.hindenburg at gmail.com
Wed Aug 8 13:43:38 UTC 2012


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105925/#review17107
-----------------------------------------------------------


projects.kde.org is down so I can't compile the code just yet.


src/IncrementalSearchBar.cpp
<http://git.reviewboard.kde.org/r/105925/#comment13396>

    I'd prefer if you used () around expressions to make it easier to read.


- Kurt Hindenburg


On Aug. 8, 2012, 11:07 a.m., Francesco Cecconi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105925/
> -----------------------------------------------------------
> 
> (Updated Aug. 8, 2012, 11:07 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> When search 'lineEdit' is focused, press 'shift+return' key, highlight the previous search result.
> 
> 
> Diffs
> -----
> 
>   src/IncrementalSearchBar.h 94f19fe 
>   src/IncrementalSearchBar.cpp dc6d7b8 
>   src/SessionController.cpp 095ac8d 
> 
> Diff: http://git.reviewboard.kde.org/r/105925/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco Cecconi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120808/5b5c7f7d/attachment.html>


More information about the konsole-devel mailing list