[Konsole-devel] Review Request: Allow konsolepart users to use the search feature

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104608/#review12709
-----------------------------------------------------------


This review has been submitted with commit cce19d8cb859c1d0e3bc2f019f68aa9b864a87f2 by Jekyll Wu to branch master.

- Commit Hook


On April 16, 2012, 2:16 a.m., Jekyll Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104608/
> -----------------------------------------------------------
> 
> (Updated April 16, 2012, 2:16 a.m.)
> 
> 
> Review request for Konsole.
> 
> 
> Description
> -------
> 
> The patch is relatively simple. There are two issures I'm not sure about:
> 
> 1. In void SessionController::updateSearchFilter(), the Q_ASSERT is made less strict, since the searchbar might be invisible when konsolepart is hidden(like in dolphin and kate)
> 
> 2. The "Find" action is currently placed beside "Scrollback", which in concept it should be put under that submenu.
> 
> 
> This addresses bug 162319.
>     http://bugs.kde.org/show_bug.cgi?id=162319
> 
> 
> Diffs
> -----
> 
>   desktop/partui.rc bc5c15a 
>   src/Part.cpp 3e5339e 
>   src/SessionController.cpp fd23e0b 
> 
> Diff: http://git.reviewboard.kde.org/r/104608/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jekyll Wu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120420/05444fe3/attachment.html>