[Konsole-devel] Review Request: Allow konsolepart users to use the search feature

[Jekyll Wu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104608/
-----------------------------------------------------------

Review request for Konsole.


Description
-------

The patch is relatively simple. There are two issures I'm not sure about:

1. In void SessionController::updateSearchFilter(), the Q_ASSERT is made less strict, since the searchbar might be invisible when konsolepart is hidden(like in dolphin and kate)

2. The "Find" action is currently placed beside "Scrollback", which in concept it should be put under that submenu.


This addresses bug 162319.
    http://bugs.kde.org/show_bug.cgi?id=162319


Diffs
-----

  desktop/partui.rc bc5c15a 
  src/Part.cpp 3e5339e 
  src/SessionController.cpp fd23e0b 

Diff: http://git.reviewboard.kde.org/r/104608/diff/


Testing
-------


Thanks,

Jekyll Wu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konsole-devel/attachments/20120416/b745d840/attachment.html>